• m_r_butts@kbin.social
    link
    fedilink
    arrow-up
    8
    arrow-down
    4
    ·
    11 months ago

    I’m not shy about using typeof for logging when it’s appropriate. Anything braver than that and you’re probably getting into reflection, which also means you’re probably not writing the code the way you should.

    • mordack550@lemmy.world
      link
      fedilink
      arrow-up
      11
      ·
      11 months ago

      Your assumption that “using reflection means the code is wrong” seems a bit extreme, at least in .Net. Every time you interact with types, you use reflection. Xml and Json serialization/deserialization uses reflection, and also Entity Framework. If you use mocking in test you are using reflection.

      We have an excel export functionality on our sites that uses reflection because we can write 1 function and export any types we want, thanks to reflection.

      • m_r_butts@kbin.social
        link
        fedilink
        arrow-up
        3
        arrow-down
        1
        ·
        11 months ago

        I said “probably”. I’m not out here blacklisting a useful tool. That would be ridiculous. If you found a situation where it was appropriate, great, more power to you. Those cases definitely exist.

        • A good sense of “code smell” is one of the most valuable programming skills. I think your “probably” is justified: if you’re doing X, you should look twice at how you’re doing it. Maybe it’s right, but usually it’s not, so it’s worth a pause and a thought.

          • dzervas@lemmy.world
            link
            fedilink
            arrow-up
            1
            ·
            11 months ago

            huh, you’re right! I’m trained on a different kind of code. In C# in particular, which I use mostly to do sneaky stuff (patch/inject runtime code to, um, “fix” it) and when I see a project that it’s too clean it smells

            I also see python code (I code regular stuff in it) that could be written much more cleanly using monkey-patching

    • _Z1useri@sopuli.xyz
      link
      fedilink
      arrow-up
      5
      ·
      11 months ago

      Hm, I’m currently working on a project with a ton of runtime-configurable plug-ins and dependencies between them. All of that is held together with a copious amount of black QMetaObject magic. I had the same thought about it, but I’m not sure how you’d get similar functionality without reflection and not making it even more convoluted and fragile…

      • xmunk@sh.itjust.works
        link
        fedilink
        arrow-up
        2
        ·
        11 months ago

        Metaprogramming is extremely useful for long term code readability. What you’re doing is probably fine but we can’t really evaluate that without seeing the actual code.