cross-posted from: https://mander.xyz/post/46665693
PieFed blocks !enoughmuskspam@lemmy.world (and a few other communities) by default. At the time of writing this post, you can search for the comm on many PieFed instances and you will not find it.
- https://feddit.online/communities?search=enoughmuskspam
- https://piefed.ca/communities?search=enoughmuskspam
- https://piefed.europe.pub/communities?search=enoughmuskspam
The block is only by default. The admin can choose to override it. Many big instances have done so, including
- piefed.social
- piefed.world
- piefed.zip
The OP linked to the function with the ‘enoughmuskspam’ filter in it: it’s here (line 352 if it doesn’t auto-scroll down).
As mentioned, it’s a bulk-community import function, that new admins can optionally use to kick-start a new instance.
The code you’ve linked to is another convenience function, for users this time, that will optionally add the relevant values to their content filters for the ‘All’ feed. It’s also not a federation block, and it’s common enough for fediverse users to want to hide posts about those people that it’s value arguably overrides any perceived messiness about ‘hard-coding’ their names.
Anyone who takes the time to understand PieFed’s codebase could find plenty of things to legitimately criticise. To my mind, though, it seems against the social contract around open-sourcing one’s hobbyist project, only for people to then be snarky about it online. If there’s bits of code that look like they were written on someone’s lunch break, that’s because they were.
The frustrating thing about this post, and the (now deleted) post before it, is that someone has taken more time to create some shit meme than they have reading the code they’re haphazardly attacking. I’ve no idea why PieFed has suddenly come under some Lemmy users sights, especially since the whole point of federated social media is that it shouldn’t matter what client someone uses, and how much it reeks of “People Front of Judea” bullshit.
It was not meant to be as harsh as it came across. And yes, this function is for logged out users, was just trying to show that it ends up messy.
I assume you’re one of the devs? I can delete the comment if you want, but I think it would be worth fixing sooner than later instead of just adding features. A lot of the mechanisms are a bad idea even if it wasn’t a mess but you do you.
There are a few implementation issues and incompatibilities I saw but not too confident in my knowledge of the protocols to say good fixes. Not sure what the Judas comment means.
I’ve contributed code to PieFed in the past, but nothing recently. If someone comes across something I’ve written and finds it amateurish, then that’s a reasonable assessment. There’s no need for you to delete your comment, as I’m not a fan of features over fixes approach either.
The “People’s Front of Judea” remark relates to a Monty Python sketch from the The Life Of Brian (youtube link) - it’s a swipe at leftist infighting (swap out “The only people we hate more than the Romans is the Judean’s People’s Front” with “The only site we hate more than Reddit is PieFed” I suppose).
It’s a bug with the latest update that has already been patched. Not sure if piefed.ca has updated their instance in response to it, but this isn’t even completely right as lemmy.ca was still returning results for “piracy” in the search.
“So since a few hours ago, when I deployed v1.6, many communities no longer show up in the search. the private value should be true or false but really old communities have it as null”
“Yes, null should be fixed to true or false. I originally added the private column many months ago, with no default value. So now the data is all over the place.”
(excerpts from the matrix chat)
OP made some assumptions, got excited and just found a bug.
Not the first time that bug’s reared its head either.
Example from here:
'nsfw': post.nsfw if post.nsfw is not None else FalseA meme about PieFed half-arsing database migrations might not be funny, but would at least be valid, and less wearisome than OP’s post.