They needed to buy time to prepare for war, it wasn’t until the nazi horde was in Stalingrad that they were ready to fight back. The nazis were going to conquer as much as they did regardless. There doesn’t seem to be any detrimental effect on reality to signing the pact.